Store and restore view focus in OnWindowFocused.

Store and restore view focus in OnWindowFocused.

Mimic [Desktop]NativeWidgetAura::OnWindowActivated.
Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls.
(View focus changes update the TextInputClient as needed)
Rewrite and enable related ConstrainedWindowViewTests.

Print GetLastError() in SendInput() error case for tests.
(key presses get 5/ERROR_ACCESS_DENIED on locked desktops?)

BUG=368691, 170331, 177482, 163931
TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.).
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271249

[msw, 2014-05-16 18:06:49]

Hey Scott, please take a look; thanks!

[sky, 2014-05-16 19:41:53]

https://codereview.chromium.org/282223002/diff/250001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right):

https://codereview.chromium.org/282223002/diff/250001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:1060: void
DesktopNativeWidgetAura::OnWindowActivated(aura::Window* gained_active,
Is this still needed after your changes? Same comment applies to
NativeWidgetAura::OnWindowActivated.

[msw, 2014-05-16 19:55:41]

https://codereview.chromium.org/282223002/diff/250001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right):

https://codereview.chromium.org/282223002/diff/250001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:1060: void
DesktopNativeWidgetAura::OnWindowActivated(aura::Window* gained_active,
On 2014/05/16 19:41:54, sky wrote:
> Is this still needed after your changes? Same comment applies to
> NativeWidgetAura::OnWindowActivated.

Sadly yes; at least for now. Without this behavior in OnWindowActivated, focus
is not restored when switching back to a window that previously had focus within
web content. I believe these are logically redundant and the OnWindowActivated
behavior could be consolidated with some unclear additional work (like ensuring
we store/restore focus to web content aura::Windows on activation changes?).

[sky, 2014-05-16 19:57:55]

*SIGH* LGTM

[msw, 2014-05-16 20:04:27]

On 2014/05/16 19:57:55, sky wrote:
> *SIGH* LGTM

:( I'm sorry... But with these re-written and re-enabled interactive ui tests
involving focus (and more, browser_focus_uitest.cc next!), I think I'll find
opportunities and confidence to consolidate this code.

[msw, 2014-05-16 20:19:17]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-05-16 20:20:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/282223002/250001

[commit-bot: I haz the power, 2014-05-17 01:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[msw, 2014-05-17 17:42:30]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-05-17 17:43:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/282223002/250001

[commit-bot: I haz the power, 2014-05-17 17:44:37]

Change committed as 271249

[ckocagil, 2014-05-18 13:50:38]

A revert of this CL has been created in
https://codereview.chromium.org/289283003/ by ckocagil@chromium.org.

The reason for reverting is: ConstrainedWindowViewTest.ClosesOnEscape introduced
in this patch fails on XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds....