Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: sdk/lib/core/sink.dart

Issue 2822173002: Warn when adding something to a closed sink and improve documentation (Closed)
Patch Set: Fix tests and update documentation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/core/sink.dart
diff --git a/sdk/lib/core/sink.dart b/sdk/lib/core/sink.dart
index 0d8f2eff254a9528e114c2d0d083265b617b0f52..596577d7c37b45915dfe8d4b8fa5f5a9f3d900e2 100644
--- a/sdk/lib/core/sink.dart
+++ b/sdk/lib/core/sink.dart
@@ -14,18 +14,18 @@ part of dart.core;
*/
abstract class Sink<T> {
/**
- * Put the data into the sink.
+ * Adds the [data] to the sink.
Bill Hesse 2017/05/03 14:10:10 Maybe drop the word "the": Adds [data] to the sink
floitsch 2017/05/03 18:28:08 Done.
*
* Must not be called after a call to [close].
*/
void add(T data);
/**
- * Tell the sink that no further data will be added.
- *
- * Calling this method more than once is allowed, but does nothing.
+ * Closes the sink.
*
* The [add] method must not be called after this method.
+ *
+ * Calling this method more than once is allowed, but does nothing.
*/
void close();
}

Powered by Google App Engine
This is Rietveld 408576698