Remove ForceReclaimResources

ui/compositor/layer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 1121 matching lines @@
   root->SetBounds(gfx::Rect(0, 0, 10, 10));
   root->SetVisible(true);
   WaitForCommit();
 
   gfx::Rect damaged_rect(0, 0, 5, 5);
   root->SchedulePaint(damaged_rect);
   EXPECT_EQ(damaged_rect, root->damaged_region_for_testing().bounds());
   WaitForCommit();
   EXPECT_TRUE(root->damaged_region_for_testing().IsEmpty());
 
-  compositor()->SetRootLayer(nullptr);
-  root.reset();
+  // The texture mailbox has a reference from an in-flight texture layer.

[ericrk, 2017/04/24 22:24:08]

Thanks for the fix!

+  // We clear the texture mailbox from the root layer and draw a new frame
+  // to ensure that the texture mailbox is released. We then draw a second
+  // frame to ensure that the mailbox's release callback has time to run.

[danakj, 2017/04/25 14:20:42]

Oh but you could also do fwiw..

make a RunLoop, and bind the QuitClosure into the mailbox release callback which
runs it, then RunLoop::Run() instead of drawing again which is kinda a heavy and
indirect way to wait for the callback?

[kylechar, 2017/04/25 16:25:01]

How does this look?

+  root->SetShowSolidColorContent();
+  compositor()->ScheduleDraw();
+  WaitForCommit();
+  compositor()->ScheduleDraw();
   WaitForCommit();
 }
 
 void ExpectRgba(int x, int y, SkColor expected_color, SkColor actual_color) {
   EXPECT_EQ(expected_color, actual_color)
       << "Pixel error at x=" << x << " y=" << y << "; "
       << "actual RGBA=("
       << SkColorGetR(actual_color) << ","
       << SkColorGetG(actual_color) << ","
       << SkColorGetB(actual_color) << ","
@@ skipping 1084 matching lines @@
   layer.set_name("foo");
   std::unique_ptr<base::trace_event::ConvertableToTraceFormat> debug_info =
       layer.TakeDebugInfo(nullptr);
   std::string trace_format("bar,");
   debug_info->AppendAsTraceFormat(&trace_format);
   std::string expected("bar,{\"layer_name\":\"foo\"}");
   EXPECT_EQ(expected, trace_format);
 }
 
 }  // namespace ui