Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/browser/renderer_host/media/audio_sync_reader.cc

Issue 2822123002: Avoid log spam in AudioSyncReader. (Closed)
Patch Set: Fix awkward comment phrasing. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/audio_sync_reader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/audio_sync_reader.cc
diff --git a/content/browser/renderer_host/media/audio_sync_reader.cc b/content/browser/renderer_host/media/audio_sync_reader.cc
index be6afd9c52278e59d6977244823a22764c9ac066..18ac79d070666078c6e7d97280c1a5650d848e84 100644
--- a/content/browser/renderer_host/media/audio_sync_reader.cc
+++ b/content/browser/renderer_host/media/audio_sync_reader.cc
@@ -53,6 +53,7 @@ AudioSyncReader::AudioSyncReader(
: shared_memory_(std::move(shared_memory)),
mute_audio_(base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kMuteAudio)),
+ had_socket_error_(false),
socket_(std::move(socket)),
foreign_socket_(std::move(foreign_socket)),
packet_size_(shared_memory_->requested_size()),
@@ -176,12 +177,18 @@ void AudioSyncReader::RequestMoreData(base::TimeDelta delay,
size_t sent_bytes = socket_->Send(&control_signal, sizeof(control_signal));
if (sent_bytes != sizeof(control_signal)) {
- const std::string error_message = "ASR: No room in socket buffer.";
- LOG(WARNING) << error_message;
- MediaStreamManager::SendMessageToNativeLog(error_message);
- TRACE_EVENT_INSTANT0("audio",
- "AudioSyncReader: No room in socket buffer",
- TRACE_EVENT_SCOPE_THREAD);
+ // Ensure we don't log consecutive errors as this can lead to a large
+ // amount of logs.
+ if (!had_socket_error_) {
+ had_socket_error_ = true;
+ const std::string error_message = "ASR: No room in socket buffer.";
+ PLOG(WARNING) << error_message;
+ MediaStreamManager::SendMessageToNativeLog(error_message);
+ TRACE_EVENT_INSTANT0("audio", "AudioSyncReader: No room in socket buffer",
+ TRACE_EVENT_SCOPE_THREAD);
+ }
+ } else {
+ had_socket_error_ = false;
}
++buffer_index_;
}
« no previous file with comments | « content/browser/renderer_host/media/audio_sync_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698