[deoptimizer] float32 stack on s390 and ppc is on lower 32 bit

src/deoptimizer.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/deoptimizer.h"
 
 #include <memory>
 
 #include "src/accessors.h"
 #include "src/assembler-inl.h"
@@ skipping 3114 matching lines @@
 uint32_t TranslatedState::GetUInt32Slot(Address fp, int slot_offset) {
   Address address = fp + slot_offset;
 #if V8_TARGET_BIG_ENDIAN && V8_HOST_ARCH_64_BIT
   return Memory::uint32_at(address + kIntSize);
 #else
   return Memory::uint32_at(address);
 #endif
 }
 
 Float32 TranslatedState::GetFloatSlot(Address fp, int slot_offset) {
+#if !V8_TARGET_ARCH_S390X && !V8_TARGET_ARCH_PPC64

[bbudge, 2017/04/24 20:49:24]

Can you just modify the GetUInt32Slot function (combining the preprocessor
directives with the ones there)? Or is there something special about float
slots?

[john.yan, 2017/04/24 21:00:53]

Yes, float/double is treated differently than int32/int64. So we can't use
GetUInt32Slot.

   return Float32::FromBits(GetUInt32Slot(fp, slot_offset));
+#else
+  return Float32::FromBits(Memory::uint32_at(fp + slot_offset));
+#endif
 }
 
 Float64 TranslatedState::GetDoubleSlot(Address fp, int slot_offset) {
   return Float64::FromBits(Memory::uint64_at(fp + slot_offset));
 }
 
 void TranslatedValue::Handlify() {
   if (kind() == kTagged) {
     value_ = Handle<Object>(raw_literal(), isolate());
     raw_literal_ = nullptr;
@@ skipping 1317 matching lines @@
       CHECK(value_info->IsMaterializedObject());
 
       value_info->value_ =
           Handle<Object>(previously_materialized_objects->get(i), isolate_);
     }
   }
 }
 
 }  // namespace internal
 }  // namespace v8