include/effects/SkXfermodeImageFilter.h - Issue 282203004: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkXfermodeImageFilter.h

Issue 282203004: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: cleanup Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkXfermodeImageFilter.h

diff --git a/include/effects/SkXfermodeImageFilter.h b/include/effects/SkXfermodeImageFilter.h

index a0cb7283644793de12b2b0e9b877b5188533ea01..c77cabaf928c0c40067191a993e6d22fd9347313 100644

--- a/include/effects/SkXfermodeImageFilter.h

+++ b/include/effects/SkXfermodeImageFilter.h

@@ -43,14 +43,10 @@ public:

#endif

protected:

- explicit SkXfermodeImageFilter(SkReadBuffer& buffer);

- virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;

-#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS

-public:

-#endif

SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* background,

SkImageFilter* foreground = NULL, const CropRect* cropRect = NULL);

scroggo 2014/05/15 14:56:42 Please remove the defaults.

+ explicit SkXfermodeImageFilter(SkReadBuffer& buffer);

+ virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;

private:

SkXfermode* fMode;