Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: include/effects/SkMergeImageFilter.h

Issue 282203004: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove default parameters in constructors. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The Android Open Source Project 2 * Copyright 2012 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkMergeImageFilter_DEFINED 8 #ifndef SkMergeImageFilter_DEFINED
9 #define SkMergeImageFilter_DEFINED 9 #define SkMergeImageFilter_DEFINED
10 10
(...skipping 12 matching lines...) Expand all
23 } 23 }
24 static SkMergeImageFilter* Create(SkImageFilter* filters[], int count, 24 static SkMergeImageFilter* Create(SkImageFilter* filters[], int count,
25 const SkXfermode::Mode modes[] = NULL, 25 const SkXfermode::Mode modes[] = NULL,
26 const CropRect* cropRect = NULL) { 26 const CropRect* cropRect = NULL) {
27 return SkNEW_ARGS(SkMergeImageFilter, (filters, count, modes, cropRect)) ; 27 return SkNEW_ARGS(SkMergeImageFilter, (filters, count, modes, cropRect)) ;
28 } 28 }
29 29
30 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkMergeImageFilter) 30 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkMergeImageFilter)
31 31
32 protected: 32 protected:
33 SkMergeImageFilter(SkReadBuffer& buffer);
34 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
35
36 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
37 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E;
38
39 #ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
40 public:
41 #endif
42 SkMergeImageFilter(SkImageFilter* first, SkImageFilter* second, 33 SkMergeImageFilter(SkImageFilter* first, SkImageFilter* second,
43 SkXfermode::Mode = SkXfermode::kSrcOver_Mode, 34 SkXfermode::Mode = SkXfermode::kSrcOver_Mode,
44 const CropRect* cropRect = NULL); 35 const CropRect* cropRect = NULL);
45 SkMergeImageFilter(SkImageFilter* filters[], int count, 36 SkMergeImageFilter(SkImageFilter* filters[], int count,
46 const SkXfermode::Mode modes[] = NULL, 37 const SkXfermode::Mode modes[] = NULL,
47 const CropRect* cropRect = NULL); 38 const CropRect* cropRect = NULL);
39 explicit SkMergeImageFilter(SkReadBuffer& buffer);
40 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
41
42 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
43 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E;
44
48 private: 45 private:
49 uint8_t* fModes; // SkXfermode::Mode 46 uint8_t* fModes; // SkXfermode::Mode
50 47
51 // private storage, to avoid dynamically allocating storage for our copy 48 // private storage, to avoid dynamically allocating storage for our copy
52 // of the modes (unless the count is so large we can't fit). 49 // of the modes (unless the count is so large we can't fit).
53 intptr_t fStorage[16]; 50 intptr_t fStorage[16];
54 51
55 void initAllocModes(); 52 void initAllocModes();
56 void initModes(const SkXfermode::Mode []); 53 void initModes(const SkXfermode::Mode []);
57 54
58 typedef SkImageFilter INHERITED; 55 typedef SkImageFilter INHERITED;
59 }; 56 };
60 57
61 #endif 58 #endif
OLDNEW
« no previous file with comments | « include/effects/SkMatrixConvolutionImageFilter.h ('k') | include/effects/SkMorphologyImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698