Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Side by Side Diff: include/effects/SkDropShadowImageFilter.h

Issue 282203004: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove default parameters in constructors. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/effects/SkDisplacementMapEffect.h ('k') | include/effects/SkEmbossMaskFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkColor.h" 8 #include "SkColor.h"
9 #include "SkImageFilter.h" 9 #include "SkImageFilter.h"
10 #include "SkScalar.h" 10 #include "SkScalar.h"
11 11
12 class SK_API SkDropShadowImageFilter : public SkImageFilter { 12 class SK_API SkDropShadowImageFilter : public SkImageFilter {
13 public: 13 public:
14 static SkDropShadowImageFilter* Create(SkScalar dx, SkScalar dy, SkScalar si gma, 14 static SkDropShadowImageFilter* Create(SkScalar dx, SkScalar dy, SkScalar si gma,
15 SkColor color, SkImageFilter* input = NULL) { 15 SkColor color, SkImageFilter* input = NULL) {
16 return SkNEW_ARGS(SkDropShadowImageFilter, (dx, dy, sigma, color, input) ); 16 return SkNEW_ARGS(SkDropShadowImageFilter, (dx, dy, sigma, color, input) );
17 } 17 }
18 static SkDropShadowImageFilter* Create(SkScalar dx, SkScalar dy, 18 static SkDropShadowImageFilter* Create(SkScalar dx, SkScalar dy,
19 SkScalar sigmaX, SkScalar sigmaY, SkC olor color, 19 SkScalar sigmaX, SkScalar sigmaY, SkC olor color,
20 SkImageFilter* input = NULL, 20 SkImageFilter* input = NULL,
21 const CropRect* cropRect = NULL) { 21 const CropRect* cropRect = NULL) {
22 return SkNEW_ARGS(SkDropShadowImageFilter, (dx, dy, sigmaX, sigmaY, 22 return SkNEW_ARGS(SkDropShadowImageFilter, (dx, dy, sigmaX, sigmaY,
23 color, input, cropRect)); 23 color, input, cropRect));
24 } 24 }
25 virtual void computeFastBounds(const SkRect&, SkRect*) const SK_OVERRIDE; 25 virtual void computeFastBounds(const SkRect&, SkRect*) const SK_OVERRIDE;
26 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDropShadowImageFilter) 26 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDropShadowImageFilter)
27 27
28 protected: 28 protected:
29 SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigma, SkColor,
30 SkImageFilter* input);
31 SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigmaX, SkScalar sigmaY, SkColor,
32 SkImageFilter* input, const CropRect* cropRect);
29 explicit SkDropShadowImageFilter(SkReadBuffer&); 33 explicit SkDropShadowImageFilter(SkReadBuffer&);
30 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE; 34 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
31 virtual bool onFilterImage(Proxy*, const SkBitmap& source, const Context&, S kBitmap* result, SkIPoint* loc) const SK_OVERRIDE; 35 virtual bool onFilterImage(Proxy*, const SkBitmap& source, const Context&, S kBitmap* result, SkIPoint* loc) const SK_OVERRIDE;
32 virtual bool onFilterBounds(const SkIRect& src, const SkMatrix&, 36 virtual bool onFilterBounds(const SkIRect& src, const SkMatrix&,
33 SkIRect* dst) const SK_OVERRIDE; 37 SkIRect* dst) const SK_OVERRIDE;
34 38
35 #ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
36 public:
37 #endif
38 SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigma, SkColor,
39 SkImageFilter* input = NULL);
40 SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigmaX, SkScalar sigmaY, SkColor,
41 SkImageFilter* input = NULL, const CropRect* cropRec t = NULL);
42
43 private: 39 private:
44 SkScalar fDx, fDy, fSigmaX, fSigmaY; 40 SkScalar fDx, fDy, fSigmaX, fSigmaY;
45 SkColor fColor; 41 SkColor fColor;
46 typedef SkImageFilter INHERITED; 42 typedef SkImageFilter INHERITED;
47 }; 43 };
OLDNEW
« no previous file with comments | « include/effects/SkDisplacementMapEffect.h ('k') | include/effects/SkEmbossMaskFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698