Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: include/core/SkXfermode.h

Issue 282203004: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove default parameters in constructors. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/core/SkPathEffect.h ('k') | include/effects/Sk1DPathEffect.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2006 The Android Open Source Project 3 * Copyright 2006 The Android Open Source Project
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 9
10 #ifndef SkXfermode_DEFINED 10 #ifndef SkXfermode_DEFINED
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 GrEffectRef** effect, 209 GrEffectRef** effect,
210 Coeff* src, 210 Coeff* src,
211 Coeff* dst, 211 Coeff* dst,
212 GrTexture* background = NULL); 212 GrTexture* background = NULL);
213 213
214 SK_TO_STRING_PUREVIRT() 214 SK_TO_STRING_PUREVIRT()
215 SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP() 215 SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP()
216 SK_DEFINE_FLATTENABLE_TYPE(SkXfermode) 216 SK_DEFINE_FLATTENABLE_TYPE(SkXfermode)
217 217
218 protected: 218 protected:
219 SkXfermode(SkReadBuffer& rb) : SkFlattenable(rb) {} 219 SkXfermode() {}
220 explicit SkXfermode(SkReadBuffer& rb) : SkFlattenable(rb) {}
220 221
221 /** The default implementation of xfer32/xfer16/xferA8 in turn call this 222 /** The default implementation of xfer32/xfer16/xferA8 in turn call this
222 method, 1 color at a time (upscaled to a SkPMColor). The default 223 method, 1 color at a time (upscaled to a SkPMColor). The default
223 implmentation of this method just returns dst. If performance is 224 implmentation of this method just returns dst. If performance is
224 important, your subclass should override xfer32/xfer16/xferA8 directly. 225 important, your subclass should override xfer32/xfer16/xferA8 directly.
225 226
226 This method will not be called directly by the client, so it need not 227 This method will not be called directly by the client, so it need not
227 be implemented if your subclass has overridden xfer32/xfer16/xferA8 228 be implemented if your subclass has overridden xfer32/xfer16/xferA8
228 */ 229 */
229 virtual SkPMColor xferColor(SkPMColor src, SkPMColor dst) const; 230 virtual SkPMColor xferColor(SkPMColor src, SkPMColor dst) const;
230 231
231 #ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
232 public:
233 #endif
234 SkXfermode() {}
235
236 private: 232 private:
237 enum { 233 enum {
238 kModeCount = kLastMode + 1 234 kModeCount = kLastMode + 1
239 }; 235 };
240 236
241 friend class SkGraphics; 237 friend class SkGraphics;
242 static void Term(); 238 static void Term();
243 239
244 typedef SkFlattenable INHERITED; 240 typedef SkFlattenable INHERITED;
245 }; 241 };
246 242
247 #endif 243 #endif
OLDNEW
« no previous file with comments | « include/core/SkPathEffect.h ('k') | include/effects/Sk1DPathEffect.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698