Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 282203002: When enable_resource_whitelist_generation==1 for release builds, pass unknown-pragmas cflags on Lin… (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

When enable_resource_whitelist_generation==1 for release builds, pass unknown-pragmas cflags on Linux and on Android. BUG=338759 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271598

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/common.gypi View 2 chunks +7 lines, -5 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-15 05:37:03 UTC) #1
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/282203002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/282203002/diff/1/build/common.gypi#newcode3098 build/common.gypi:3098: ['_toolset=="target"', { is this true for Release Official ...
6 years, 7 months ago (2014-05-15 23:05:05 UTC) #2
Lei Zhang
https://codereview.chromium.org/282203002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/282203002/diff/1/build/common.gypi#newcode3098 build/common.gypi:3098: ['_toolset=="target"', { On 2014/05/15 23:05:05, aurimas wrote: > is ...
6 years, 7 months ago (2014-05-20 03:42:42 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-20 03:42:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/282203002/1
6 years, 7 months ago (2014-05-20 03:43:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 05:34:36 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:50:24 UTC) #7
Message was sent while issue was closed.
Change committed as 271598

Powered by Google App Engine
This is Rietveld 408576698