Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: net/quic/core/quic_versions_test.cc

Issue 2822023005: deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_versions.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_versions_test.cc
diff --git a/net/quic/core/quic_versions_test.cc b/net/quic/core/quic_versions_test.cc
index 6f3dc921313f11c019ea3b7957fdffb82e5afc31..d8089c29bf768ac159b0e475a0a820fdfa12d020 100644
--- a/net/quic/core/quic_versions_test.cc
+++ b/net/quic/core/quic_versions_test.cc
@@ -125,25 +125,11 @@ TEST(QuicVersionsTest, QuicVersionToString) {
}
}
-TEST(QuicVersionsTest, FilterSupportedVersionsNo36) {
- QuicFlagSaver flags;
- QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
- QUIC_VERSION_37};
-
- FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = false;
- FLAGS_quic_reloadable_flag_quic_enable_version_37 = false;
-
- QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
- ASSERT_EQ(1u, filtered_versions.size());
- EXPECT_EQ(QUIC_VERSION_35, filtered_versions[0]);
-}
-
TEST(QuicVersionsTest, FilterSupportedVersionsNo37) {
QuicFlagSaver flags;
QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
QUIC_VERSION_37};
- FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = true;
FLAGS_quic_reloadable_flag_quic_enable_version_37 = false;
QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
@@ -157,7 +143,6 @@ TEST(QuicVersionsTest, FilterSupportedVersionsAllVersions) {
QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
QUIC_VERSION_37};
- FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = true;
FLAGS_quic_reloadable_flag_quic_enable_version_37 = true;
QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
« no previous file with comments | « net/quic/core/quic_versions.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698