Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: net/quic/core/quic_version_manager_test.cc

Issue 2822023005: deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_version_manager.cc ('k') | net/quic/core/quic_versions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_version_manager_test.cc
diff --git a/net/quic/core/quic_version_manager_test.cc b/net/quic/core/quic_version_manager_test.cc
index e80cbffa73038c63e3974c6204f73bf2dffb7271..848f1afc5c15c4b26e2f94e60efa3b6f95a477cd 100644
--- a/net/quic/core/quic_version_manager_test.cc
+++ b/net/quic/core/quic_version_manager_test.cc
@@ -16,20 +16,12 @@ namespace {
TEST(QuicVersionManagerTest, QuicVersionManager) {
QuicFlagSaver flags;
- FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = false;
FLAGS_quic_reloadable_flag_quic_enable_version_38 = false;
FLAGS_quic_reloadable_flag_quic_enable_version_37 = false;
QuicVersionManager manager(AllSupportedVersions());
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
- FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = true;
- EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
- manager.GetSupportedVersions());
- ASSERT_EQ(2u, manager.GetSupportedVersions().size());
- EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[0]);
- EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[1]);
-
FLAGS_quic_reloadable_flag_quic_enable_version_37 = true;
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
« no previous file with comments | « net/quic/core/quic_version_manager.cc ('k') | net/quic/core/quic_versions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698