chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc - Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)

Patch Set: code review changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/background_loader_offliner.cc ('K') | « chrome/browser/android/offline_pages/background_loader_offliner.cc ('k') | chrome/browser/android/offline_pages/prerendering_loader.cc » ('j') | components/offline_pages/core/snapshot_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

index 15df60d4a44755e8d2c0e5b358d4240259e3e36f..9ff457061e661e94dc0e499f44b13597fe7b9a15 100644

--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

@@ -189,7 +189,10 @@ void BackgroundLoaderOfflinerTest::SetUp() {

policy_.reset(new OfflinerPolicy());

offliner_.reset(

new TestBackgroundLoaderOffliner(profile(), policy_.get(), model_));

- offliner_->SetPageDelayForTest(0L);

+ offliner_->SetSnapshotControllerForTest(new SnapshotController(

+ base::ThreadTaskRunnerHandle::Get(), offliner_.get(),

+ 0L /* DelayAfterDocumentAvailable */, 0L /* DelayAfterDocumentOnLoad */,

+ false /* DocumentAvailableTriggersSnapshot */));

}

void BackgroundLoaderOfflinerTest::OnCompletion(