Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.h

Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)
Patch Set: code review changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h
index 25378b73e41864d594e793efe253f50f4c63f74d..b3eb52ff7587cb2e6c610d0cc183bc740b0f54ef 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h
@@ -57,7 +57,7 @@ class BackgroundLoaderOffliner : public Offliner,
// SnapshotController::Client implementation.
void StartSnapshot() override;
- void SetPageDelayForTest(long delay_ms);
+ void SetSnapshotControllerForTest(SnapshotController* controller);
void OnNetworkBytesChanged(int64_t bytes);
protected:
@@ -103,8 +103,6 @@ class BackgroundLoaderOffliner : public Offliner,
SaveState save_state_;
// Page load state.
PageLoadState page_load_state_;
- // Seconds to delay before taking snapshot.
- long page_delay_ms_;
// Network bytes loaded.
int64_t network_bytes_;
// Whether the low bar of snapshot quality has been met.

Powered by Google App Engine
This is Rietveld 408576698