[Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the …

components/offline_pages/core/snapshot_controller.h

Index: components/offline_pages/core/snapshot_controller.h
diff --git a/components/offline_pages/core/snapshot_controller.h b/components/offline_pages/core/snapshot_controller.h
index 36e1680a6f03f515a7c0305eef0669a6602796d6..62b7750524a2da3a60924a8d17d6408ebd9c5913 100644
--- a/components/offline_pages/core/snapshot_controller.h
+++ b/components/offline_pages/core/snapshot_controller.h
@@ -67,7 +67,8 @@ class SnapshotController {
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       SnapshotController::Client* client,
       int64_t delay_after_document_available_ms,
-      int64_t delay_after_document_on_load_completed_ms);
+      int64_t delay_after_document_on_load_completed_ms,
+      bool consider_document_available_for_snapshot);
   virtual ~SnapshotController();
 
   // Resets the 'session', returning controller to initial state.
@@ -103,6 +104,7 @@ class SnapshotController {
   SnapshotController::State state_;
   int64_t delay_after_document_available_ms_;
   int64_t delay_after_document_on_load_completed_ms_;
+  bool consider_document_available_for_snapshot_;

[carlosk, 2017/04/19 23:16:57]

nit: it seems to me that prefixing with "consider" makes its intent less less
clear than it would be with "ignore".

[fgorski, 2017/04/20 16:39:05]

I too have hard time reading this variable:

document_available_triggers_snapshot_ maybe?

[chili, 2017/04/21 00:12:54]

I think I prefer a "positive" over "negative" link. i.e. If I change the name to
"ShouldIgnoreDocumentAvailableForSnapshot", then passing 'false' would imply we
shouldn't ignore - aka we should use it. Similarly, a 'true' would mean we
shouldn't use it.

Filip suggested document_available_triggers_snapshot. Is this ok with you?

[carlosk, 2017/04/21 01:10:58]

It is. I find this naming to be just as clear as the ignore*.

 
   // The expected quality of a snapshot taken at the moment this value is
   // queried.