Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2401)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)
Patch Set: some fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index 60f8c50e8eb6e661da69c3660ac1af31d9ff11b2..55d915c36eda6390fdbcfef0943b284d427b90f9 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -170,9 +170,9 @@ bool BackgroundLoaderOffliner::LoadAndSave(
// Load page attempt.
loader_.get()->LoadPage(request.url());
- snapshot_controller_.reset(
- new SnapshotController(base::ThreadTaskRunnerHandle::Get(), this,
- kOfflineDomContentLoadedMs, page_delay_ms_));
+ snapshot_controller_.reset(new SnapshotController(
+ base::ThreadTaskRunnerHandle::Get(), this, kOfflineDomContentLoadedMs,
carlosk 2017/04/19 23:16:57 As the DOM content loaded delay is now ignored thi
fgorski 2017/04/20 16:39:05 Since this is the only place the constant is used,
chili 2017/04/21 00:12:54 Done.
+ page_delay_ms_, false /* consider_document_available_for_snapshot */));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698