Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.cc

Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)
Patch Set: test fix: replace snapshot controller at the right place Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index df12f0b883900b2f4a62fcf603be2861973d76e2..5eccbf9f696600b8045c7cfbf5e1cf3c315d6fe7 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -16,20 +16,8 @@
#include "net/base/network_change_notifier.h"
#include "ui/gfx/geometry/size.h"
-namespace {
-// Whether to report DomContentLoaded event to the snapshot controller.
-bool kConsiderDclForSnapshot = false;
-// The delay to wait for snapshotting after DomContentLoaded event if
-// kConsiderDclForSnapshot is true.
-long kOfflinePageDclDelayMs = 25000;
-// The delay to wait for snapshotting after OnLoad event.
-long kOfflinePageOnloadDelayMs = 2000;
-} // namespace
-
-
namespace offline_pages {
-
// Classifies the appropriate RequestStatus for for the given prerender
// FinalStatus.
Offliner::RequestStatus ClassifyFinalStatus(
@@ -128,10 +116,8 @@ bool PrerenderingLoader::LoadPage(const GURL& url,
return false;
DCHECK(adapter_->IsActive());
- snapshot_controller_.reset(
- new SnapshotController(base::ThreadTaskRunnerHandle::Get(), this,
- kOfflinePageDclDelayMs,
- kOfflinePageOnloadDelayMs));
+ snapshot_controller_ = SnapshotController::CreateForBackgroundOfflining(
+ base::ThreadTaskRunnerHandle::Get(), this);
load_done_callback_ = load_done_callback;
progress_callback_ = progress_callback;
session_contents_.swap(new_web_contents);
@@ -180,12 +166,10 @@ void PrerenderingLoader::OnPrerenderDomContentLoaded() {
HandleLoadingStopped();
} else {
is_lowbar_met_ = true;
- if (kConsiderDclForSnapshot) {
- // Inform SnapshotController of DomContentLoaded event so it can
- // determine when to consider it really LOADED (e.g., some multiple
- // second delay from this event).
- snapshot_controller_->DocumentAvailableInMainFrame();
- }
+ // Inform SnapshotController of DomContentLoaded event so it can
+ // determine when to consider it really LOADED (e.g., some multiple
+ // second delay from this event).
+ snapshot_controller_->DocumentAvailableInMainFrame();
// Add this signal to signal_data_.
AddLoadingSignal("OnDomContentLoaded");

Powered by Google App Engine
This is Rietveld 408576698