Fix an issue with restoring certain lint issues from summary files.

Fix an issue with restoring certain lint issues from summary files.

BUG=https://github.com/dart-lang/sdk/issues/29359
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/310d6d196b50077e145567c1f3e45292ae775478

[devoncarew, 2017-04-18 15:05:25]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, pquitslund@google.com, scheglov@google.com

[devoncarew, 2017-04-18 15:05:26]

Fix an issue restoring some lints from summary files. The restore code could
only handle lints with a full code starting with `_LintCode.`. Most lints were
created using the _LintCode class, but 5-6 types of lints are created directly
using the parent LintCode class. This changes the lint restoring code to accept
either _LintCode. or LintCode. prefix, and normalizes the fully qualified ids of
lint issues to all start with 'LintCode.'.

[scheglov, 2017-04-18 15:19:54]

LGTM

https://codereview.chromium.org/2821943003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2821943003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1182: final String lintPrefix =
'LintCode.';
"const String"?

[Brian Wilkerson, 2017-04-18 15:35:56]

lgtm

[devoncarew, 2017-04-18 15:48:37]

https://codereview.chromium.org/2821943003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2821943003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1182: final String lintPrefix =
'LintCode.';
On 2017/04/18 15:19:54, scheglov wrote:
> "const String"?

Done.

[devoncarew, 2017-04-18 15:50:28]

Description was changed from

==========
Fix an issue with restoring certain lint issues from summary files.

BUG=https://github.com/dart-lang/sdk/issues/29359
==========

to

==========
Fix an issue with restoring certain lint issues from summary files.

BUG=https://github.com/dart-lang/sdk/issues/29359
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/310d6d196b50077e145567c1f3e45292ae775478
==========

[devoncarew, 2017-04-18 15:50:29]

Committed patchset #2 (id:20001) manually as
310d6d196b50077e145567c1f3e45292ae775478 (presubmit successful).