[AiS] Enable AiS flag on all platforms

[AiS] Enable AiS flag on all platforms

As discussed in crrev.com/276073002, enabling the flag on all platforms
simplifies code and has no negative impact.

BUG=370192
R=pkasting@chromium.org
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271214

[groby-ooo-7-16, 2014-05-15 19:15:09]

Peter: Here's the removal of a bunch of OS_ANDROID stuff we talked about.

[Peter Kasting, 2014-05-15 20:30:55]

LGTM

https://codereview.chromium.org/282183002/diff/1/chrome/browser/search/search.cc
File chrome/browser/search/search.cc (right):

https://codereview.chromium.org/282183002/diff/1/chrome/browser/search/search...
chrome/browser/search/search.cc:513: bool IsAnswersInSuggestEnabled() {
I'd prefer not to create a helper for this.  (The chrome namespace is supposed
to die anyway, and this is effectively a global in it.)

Let's just have callers check the command line directly.

[groby-ooo-7-16, 2014-05-15 22:32:37]

https://codereview.chromium.org/282183002/diff/1/chrome/browser/search/search.cc
File chrome/browser/search/search.cc (right):

https://codereview.chromium.org/282183002/diff/1/chrome/browser/search/search...
chrome/browser/search/search.cc:513: bool IsAnswersInSuggestEnabled() {
On 2014/05/15 20:30:55, Peter Kasting wrote:
> I'd prefer not to create a helper for this.  (The chrome namespace is supposed
> to die anyway, and this is effectively a global in it.)
> 
> Let's just have callers check the command line directly.

Done.

[groby-ooo-7-16, 2014-05-15 22:33:04]

brettw: Removed an extraneous semicolon - can I has owner RS?

[Peter Kasting, 2014-05-15 22:35:17]

On 2014/05/15 22:33:04, groby wrote:
> brettw: Removed an extraneous semicolon - can I has owner RS?

You can TBR that kind of a change.

Incidentally, I'm also removing that semicolon in a CL that touches search.cc
for various other reasons, so feel free to ignore it if you want.

[groby-ooo-7-16, 2014-05-15 23:08:09]

Sigh. I can't believe I forgot about TBR. Thanks!

[groby-ooo-7-16, 2014-05-15 23:08:15]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-15 23:11:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/282183002/20001

[commit-bot: I haz the power, 2014-05-16 03:22:44]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-16 03:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 03:32:27]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[groby-ooo-7-16, 2014-05-16 19:31:20]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-16 19:32:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/282183002/20002

[commit-bot: I haz the power, 2014-05-17 15:53:28]

Change committed as 271214