Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: device/usb/usb_device_handle_unittest.cc

Issue 2821813002: Use Mojo enum types in the C++ USB interface (Closed)
Patch Set: Fix up //device/usb dependencies in //extensions/browser/api Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_device_handle_impl.cc ('k') | device/usb/usb_device_handle_usbfs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_device_handle_unittest.cc
diff --git a/device/usb/usb_device_handle_unittest.cc b/device/usb/usb_device_handle_unittest.cc
index ab20c41340084c6bf1c963b30b372b1802e0c42f..20a76e4f24443ae7a729919c26acb081881c4e3b 100644
--- a/device/usb/usb_device_handle_unittest.cc
+++ b/device/usb/usb_device_handle_unittest.cc
@@ -147,7 +147,7 @@ TEST_F(UsbDeviceHandleTest, InterruptTransfer) {
scoped_refptr<net::IOBufferWithSize> in_buffer(new net::IOBufferWithSize(64));
TestCompletionCallback in_completion;
- handle->GenericTransfer(USB_DIRECTION_INBOUND, 0x81, in_buffer.get(),
+ handle->GenericTransfer(UsbTransferDirection::INBOUND, 0x81, in_buffer.get(),
in_buffer->size(),
5000, // 5 second timeout
in_completion.callback());
@@ -159,17 +159,17 @@ TEST_F(UsbDeviceHandleTest, InterruptTransfer) {
out_buffer->data()[i] = i;
}
- handle->GenericTransfer(USB_DIRECTION_OUTBOUND, 0x01, out_buffer.get(),
- out_buffer->size(),
+ handle->GenericTransfer(UsbTransferDirection::OUTBOUND, 0x01,
+ out_buffer.get(), out_buffer->size(),
5000, // 5 second timeout
out_completion.callback());
out_completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_COMPLETED, out_completion.status());
+ ASSERT_EQ(UsbTransferStatus::COMPLETED, out_completion.status());
EXPECT_EQ(static_cast<size_t>(out_buffer->size()),
out_completion.transferred());
in_completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_COMPLETED, in_completion.status());
+ ASSERT_EQ(UsbTransferStatus::COMPLETED, in_completion.status());
EXPECT_EQ(static_cast<size_t>(in_buffer->size()),
in_completion.transferred());
for (size_t i = 0; i < in_completion.transferred(); ++i) {
@@ -216,7 +216,7 @@ TEST_F(UsbDeviceHandleTest, BulkTransfer) {
scoped_refptr<net::IOBufferWithSize> in_buffer(
new net::IOBufferWithSize(512));
TestCompletionCallback in_completion;
- handle->GenericTransfer(USB_DIRECTION_INBOUND, 0x82, in_buffer.get(),
+ handle->GenericTransfer(UsbTransferDirection::INBOUND, 0x82, in_buffer.get(),
in_buffer->size(),
5000, // 5 second timeout
in_completion.callback());
@@ -228,17 +228,17 @@ TEST_F(UsbDeviceHandleTest, BulkTransfer) {
out_buffer->data()[i] = i;
}
- handle->GenericTransfer(USB_DIRECTION_OUTBOUND, 0x02, out_buffer.get(),
- out_buffer->size(),
+ handle->GenericTransfer(UsbTransferDirection::OUTBOUND, 0x02,
+ out_buffer.get(), out_buffer->size(),
5000, // 5 second timeout
out_completion.callback());
out_completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_COMPLETED, out_completion.status());
+ ASSERT_EQ(UsbTransferStatus::COMPLETED, out_completion.status());
EXPECT_EQ(static_cast<size_t>(out_buffer->size()),
out_completion.transferred());
in_completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_COMPLETED, in_completion.status());
+ ASSERT_EQ(UsbTransferStatus::COMPLETED, in_completion.status());
EXPECT_EQ(static_cast<size_t>(in_buffer->size()),
in_completion.transferred());
for (size_t i = 0; i < in_completion.transferred(); ++i) {
@@ -268,11 +268,12 @@ TEST_F(UsbDeviceHandleTest, ControlTransfer) {
scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(255));
TestCompletionCallback completion;
- handle->ControlTransfer(USB_DIRECTION_INBOUND, UsbDeviceHandle::STANDARD,
- UsbDeviceHandle::DEVICE, 0x06, 0x0301, 0x0409, buffer,
- buffer->size(), 0, completion.callback());
+ handle->ControlTransfer(
+ UsbTransferDirection::INBOUND, UsbControlTransferType::STANDARD,
+ UsbControlTransferRecipient::DEVICE, 0x06, 0x0301, 0x0409, buffer,
+ buffer->size(), 0, completion.callback());
completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_COMPLETED, completion.status());
+ ASSERT_EQ(UsbTransferStatus::COMPLETED, completion.status());
const char expected_str[] = "\x18\x03G\0o\0o\0g\0l\0e\0 \0I\0n\0c\0.\0";
EXPECT_EQ(sizeof(expected_str) - 1, completion.transferred());
for (size_t i = 0; i < completion.transferred(); ++i) {
@@ -334,14 +335,14 @@ TEST_F(UsbDeviceHandleTest, CancelOnClose) {
scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(512));
TestCompletionCallback completion;
- handle->GenericTransfer(USB_DIRECTION_INBOUND, 0x82, buffer.get(),
+ handle->GenericTransfer(UsbTransferDirection::INBOUND, 0x82, buffer.get(),
buffer->size(),
5000, // 5 second timeout
completion.callback());
handle->Close();
completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_CANCELLED, completion.status());
+ ASSERT_EQ(UsbTransferStatus::CANCELLED, completion.status());
}
TEST_F(UsbDeviceHandleTest, CancelOnDisconnect) {
@@ -365,14 +366,14 @@ TEST_F(UsbDeviceHandleTest, CancelOnDisconnect) {
scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(512));
TestCompletionCallback completion;
- handle->GenericTransfer(USB_DIRECTION_INBOUND, 0x82, buffer.get(),
+ handle->GenericTransfer(UsbTransferDirection::INBOUND, 0x82, buffer.get(),
buffer->size(),
5000, // 5 second timeout
completion.callback());
ASSERT_TRUE(gadget->Disconnect());
completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_DISCONNECT, completion.status());
+ ASSERT_EQ(UsbTransferStatus::DISCONNECT, completion.status());
handle->Close();
}
@@ -398,13 +399,13 @@ TEST_F(UsbDeviceHandleTest, Timeout) {
scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(512));
TestCompletionCallback completion;
- handle->GenericTransfer(USB_DIRECTION_INBOUND, 0x82, buffer.get(),
+ handle->GenericTransfer(UsbTransferDirection::INBOUND, 0x82, buffer.get(),
buffer->size(),
10, // 10 millisecond timeout
completion.callback());
completion.WaitForResult();
- ASSERT_EQ(USB_TRANSFER_TIMEOUT, completion.status());
+ ASSERT_EQ(UsbTransferStatus::TIMEOUT, completion.status());
handle->Close();
}
« no previous file with comments | « device/usb/usb_device_handle_impl.cc ('k') | device/usb/usb_device_handle_usbfs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698