chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java - Issue 2821793002: Defocus omnibox on back if keyboard hides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2821793002: Defocus omnibox on back if keyboard hides. (Closed)

Patch Set: Add comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/KeyboardHideHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

index 8ef70af240940bf7390d3c5033cf04a5ad35d1da..0892e8cacd79fc1ad2a1088d0ac873cbce0c34b2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -790,6 +790,7 @@ public class LocationBarLayout extends FrameLayout

mWindowDelegate = windowDelegate;

mWindowAndroid = windowAndroid;

+ mUrlBar.setWindowDelegate(windowDelegate);

// If the user focused the omnibox prior to the native libraries being initialized,

// autocomplete will not always be enabled, so we force it enabled in that case.

mUrlBar.setIgnoreTextChangesForAutocomplete(false);

@@ -2013,8 +2014,8 @@ public class LocationBarLayout extends FrameLayout

}

- // TODO(dfalcantara): Make private again after M58.

- protected void backKeyPressed() {

+ @Override

+ public void backKeyPressed() {

hideSuggestions();

UiUtils.hideKeyboard(mUrlBar);

// Revert the URL to match the current page.