Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2821733002: Fix clipping of squashed sibling layers with border radius masks (Closed)
Patch Set: Test will fail in SPv2 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
index f9320de2ecbc1121d69e6f67d14d7989fe630dc2..7537e0d0548627b017f8c1871bd45686ecd8df68 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
@@ -961,7 +961,9 @@ void PaintLayerPainter::PaintFragmentWithPhase(
case kPaintPhaseSelfBlockBackgroundOnly: // Background painting will
// handle clipping to self.
case kPaintPhaseSelfOutlineOnly:
- case kPaintPhaseMask: // Mask painting will handle clipping to self.
+ case kPaintPhaseMask:
+ case kPaintPhaseClippingMask:
chrishtr 2017/04/17 17:25:00 Your fix is generally correct, just a small error.
+ // Mask painting will handle clipping to self.
clipping_rule = LayerClipRecorder::kDoNotIncludeSelfForBorderRadius;
break;
default:

Powered by Google App Engine
This is Rietveld 408576698