Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2821683002: Flush on write in FileByteStore. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flush on write in FileByteStore. We see (rarely, but still) situations when FileState attempts to read a *.unlinked file, but the file is empty. We think that this happens when the user's machine crashes, so files are created, but not fully written to disk. This change has its cost - increase of FileByteStore.put() CPU usage from 7% to 10% on Mac. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2d0d00061190d1df824628e7ec045ece27af7fd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-14 17:48:05 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-14 17:49:26 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 2d0d00061190d1df824628e7ec045ece27af7fd1 (presubmit successful).
3 years, 8 months ago (2017-04-14 17:53:29 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-17 17:29:09 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698