third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py - Issue 2821543003: In run-webkit-tests, start xvfb if necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

Issue 2821543003: In run-webkit-tests, start xvfb if necessary. (Closed)

Patch Set: Check process after starting, wait after killing, change stderr redirect to DEVNULL Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

index 670b728660acf97560e6f73e7e783388871899dd..2b910bc262af3cb7d78a54ffe97ef4a6d846d082 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

@@ -56,6 +56,9 @@ class MockProcess(object):

def communicate(self, *_):

return (self.stdout.getvalue(), self.stderr.getvalue())

+ def kill(self):

+ return

class MockExecutive(object):

PIPE = 'MOCK PIPE'

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('j') | no next file with comments »