chrome/browser/notifications/displayed_notifications_dispatch_callback.h - Issue 2821533003: Refactor NotificationPlatformBridgeLinux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/notifications/displayed_notifications_dispatch_callback.h

Issue 2821533003: Refactor NotificationPlatformBridgeLinux (Closed)

Patch Set: fix compile errors Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/notifications/DEPS ('k') | chrome/browser/notifications/native_notification_display_service.h » ('j') | chrome/browser/notifications/notification_platform_bridge.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_NOTIFICATIONS_DISPLAYED_NOTIFICATIONS_DISPATCH_CALLBACK_H _	5 #ifndef CHROME_BROWSER_NOTIFICATIONS_DISPLAYED_NOTIFICATIONS_DISPATCH_CALLBACK_H _

6 #define CHROME_BROWSER_NOTIFICATIONS_DISPLAYED_NOTIFICATIONS_DISPATCH_CALLBACK_H _	6 #define CHROME_BROWSER_NOTIFICATIONS_DISPLAYED_NOTIFICATIONS_DISPATCH_CALLBACK_H _

7	7

8 #include <set>	8 #include <set>

9	9

10 #include "base/callback.h"	10 #include "base/callback.h"

11	11

12 // Callback used by the bridge and all the downstream classes that propagate	12 // Callback used by the bridge and all the downstream classes that propagate

13 // the callback to get displayed notifications.	13 // the callback to get displayed notifications.

14 using GetDisplayedNotificationsCallback =	14 using GetDisplayedNotificationsCallback =

15 base::Callback<void(std::unique_ptr<std::set<std::string>>,	15 base::Callback<void(std::unique_ptr<std::set<std::string>>,

16 bool /* supports_synchronization */)>;	16 bool /* supports_synchronization */)>;

17	17

	18 using NotificationBridgeReadyCallback =
	Peter Beverloo 2017/04/26 13:53:36 micro nit: make this a public member of Notificati micro nit: make this a public member of NotificationPlatformBridge. The other callback is defined in this file because it's used throughout the Mac platform bridge, which has several components and an XPC service in it. Tom (Use chromium acct) 2017/04/26 17:56:53 Done. Show quoted text On 2017/04/26 13:53:36, Peter Beverloo wrote: > micro nit: make this a public member of NotificationPlatformBridge. The other > callback is defined in this file because it's used throughout the Mac platform > bridge, which has several components and an XPC service in it. Done.
	19 base::OnceCallback<void(bool /* success */)>;

	20

18 #endif // CHROME_BROWSER_NOTIFICATIONS_DISPLAYED_NOTIFICATIONS_DISPATCH_CALLBAC K_H_	21 #endif // CHROME_BROWSER_NOTIFICATIONS_DISPLAYED_NOTIFICATIONS_DISPATCH_CALLBAC K_H_

OLD	NEW