third_party/WebKit/PerformanceTests/Bindings/sequence-conversion-array.html - Issue 2821493002: bindings: Add performance test for JS->WebIDL sequence conversions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/PerformanceTests/Bindings/sequence-conversion-array.html

Issue 2821493002: bindings: Add performance test for JS->WebIDL sequence conversions. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/runner.js"></script>

	5 <script>

	6 let dataArray = [];

	7 for (let i = 0; i < 100000; i++)

	8 dataArray.push('abcdefg foo bar baz');
	Yuki 2017/04/14 07:50:44 Will this v8::String be converted to blink::String Will this v8::String be converted to blink::String or something? If we'd like to measure the pure overhead of v8::Array => IDLSequence, then we wouldn't be interested in the content nor content's conversion. Maybe simple zero or boolean would be better? Raphael Kubo da Costa (rakuco) 2017/04/14 08:09:10 Since the string conversion is still going to happ Show quoted text On 2017/04/14 07:50:44, Yuki wrote: > Will this v8::String be converted to blink::String or something? > > If we'd like to measure the pure overhead of v8::Array => IDLSequence, then we > wouldn't be interested in the content nor content's conversion. Maybe simple > zero or boolean would be better? Since the string conversion is still going to happen due to Blob's constructor not taking numbers or booleans, how about an empty string instead? Yuki 2017/04/14 08:27:58 An empty string makes sense to me. Show quoted text On 2017/04/14 08:09:10, Raphael Kubo da Costa (rakuco) wrote: > On 2017/04/14 07:50:44, Yuki wrote: > > Will this v8::String be converted to blink::String or something? > > > > If we'd like to measure the pure overhead of v8::Array => IDLSequence, then we > > wouldn't be interested in the content nor content's conversion. Maybe simple > > zero or boolean would be better? > > Since the string conversion is still going to happen due to Blob's constructor > not taking numbers or booleans, how about an empty string instead? An empty string makes sense to me.
	9

	10 PerfTestRunner.measureRunsPerSecond({

	11 description: "This benchmark measures the overhead of converting JavaScript ob jects into WebIDL sequences (fast path for arrays)",

	12 run: function() {

	13 new Blob(dataArray);

	14 }});

	15 </script>

	16 </body>

	17 </html>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »