android_webview/browser/aw_content_browser_client.cc - Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)

Patch Set: associated with IPC channel Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_content_browser_client.cc

diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc

index 749d724459f102e1bfce9489f97f4c998b971390..dcfc10994af221b9b0d6341beebb98faffcee2d2 100644

--- a/android_webview/browser/aw_content_browser_client.cc

+++ b/android_webview/browser/aw_content_browser_client.cc

@@ -417,7 +417,6 @@ bool AwContentBrowserClient::CanCreateWindow(

const blink::mojom::WindowFeatures& features,

bool user_gesture,

bool opener_suppressed,

- content::ResourceContext* context,

bool* no_javascript_access) {

// We unconditionally allow popup windows at this stage and will give

// the embedder the opporunity to handle displaying of the popup in