Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/public/test/mock_render_thread.cc

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)
Patch Set: MakeShared goodness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/mock_render_thread.cc
diff --git a/content/public/test/mock_render_thread.cc b/content/public/test/mock_render_thread.cc
index c953a5d206d4ea5511e8e3791a0d461bdf6f2e6d..0c02a0d3ce88aa72e948e7fc9e93a1f550239f19 100644
--- a/content/public/test/mock_render_thread.cc
+++ b/content/public/test/mock_render_thread.cc
@@ -41,22 +41,6 @@ class MockRenderMessageFilterImpl : public mojom::RenderMessageFilter {
callback.Run(MSG_ROUTING_NONE);
}
- void CreateNewWindow(mojom::CreateNewWindowParamsPtr params,
- const CreateNewWindowCallback& callback) override {
- // NOTE: This implementation of mojom::RenderMessageFilter is used client-
- // side only. Because sync mojom methods have a different interface for
- // bindings- and client-side, we only implement the client-side interface
- // on this object.
- NOTREACHED();
- }
-
- bool CreateNewWindow(mojom::CreateNewWindowParamsPtr params,
- mojom::CreateNewWindowReplyPtr* reply) override {
- *reply = mojom::CreateNewWindowReply::New();
- thread_->OnCreateWindow(*params, reply->get());
- return true;
- }
-
void CreateNewWidget(int32_t opener_id,
blink::WebPopupType popup_type,
const CreateNewWidgetCallback& callback) override {

Powered by Google App Engine
This is Rietveld 408576698