Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: content/public/browser/content_browser_client.h

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)
Patch Set: MakeShared goodness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index f360af58e0c3c3613fb5d3b86bd224d49d289a19..0cfdf64fd5af4962c83b38ad7f82382546ce58b7 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -501,10 +501,9 @@ class CONTENT_EXPORT ContentBrowserClient {
// Returns true if the given page is allowed to open a window of the given
// type. If true is returned, |no_javascript_access| will indicate whether
// the window that is created should be scriptable/in the same process.
- // This is called on the IO thread.
+ // This is called on the UI thread.
virtual bool CanCreateWindow(
- int opener_render_process_id,
- int opener_render_frame_id,
+ RenderFrameHost* opener,
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
@@ -516,7 +515,6 @@ class CONTENT_EXPORT ContentBrowserClient {
const blink::mojom::WindowFeatures& features,
bool user_gesture,
bool opener_suppressed,
- ResourceContext* context,
bool* no_javascript_access);
// Notifies the embedder that the ResourceDispatcherHost has been created.

Powered by Google App Engine
This is Rietveld 408576698