Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1841)

Unified Diff: content/browser/renderer_host/render_widget_helper.h

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)
Patch Set: MakeShared goodness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_helper.h
diff --git a/content/browser/renderer_host/render_widget_helper.h b/content/browser/renderer_host/render_widget_helper.h
index 3e46e2c12169b1755a62bdd9c911e402c740198a..ffd67fef61e3c93e08a42fea8d817db1a4067cb1 100644
--- a/content/browser/renderer_host/render_widget_helper.h
+++ b/content/browser/renderer_host/render_widget_helper.h
@@ -22,8 +22,8 @@
#include "ui/gfx/native_widget_types.h"
namespace content {
+
class ResourceDispatcherHostImpl;
-class SessionStorageNamespace;
// Instantiated per RenderProcessHost to provide various optimizations on
// behalf of a RenderWidgetHost. This class bridges between the IO thread
@@ -56,13 +56,6 @@ class RenderWidgetHelper
void ResumeDeferredNavigation(const GlobalRequestID& request_id);
// IO THREAD ONLY -----------------------------------------------------------
-
- void CreateNewWindow(mojom::CreateNewWindowParamsPtr params,
- bool no_javascript_access,
- int32_t* render_view_route_id,
- int32_t* main_frame_route_id,
- int32_t* main_frame_widget_route_id,
- SessionStorageNamespace* session_storage_namespace);
void CreateNewWidget(int opener_id,
blink::WebPopupType popup_type,
int* route_id);
@@ -75,14 +68,6 @@ class RenderWidgetHelper
~RenderWidgetHelper();
- // Called on the UI thread to finish creating a window.
- void OnCreateNewWindowOnUI(
- mojom::CreateNewWindowParamsPtr params,
- int32_t render_view_route_id,
- int32_t main_frame_route_id,
- int32_t main_frame_widget_route_id,
- SessionStorageNamespace* session_storage_namespace);
-
// Called on the UI thread to finish creating a widget.
void OnCreateWidgetOnUI(int32_t opener_id,
int32_t route_id,

Powered by Google App Engine
This is Rietveld 408576698