content/browser/web_contents/web_contents_impl.h - Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)

Patch Set: security exploit test passes a non null callback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 5a621c32adb4b39566006e10f588efde2b39d2f2..7a5368a0de583d6e4c1168fb8bcdde60c3796eb4 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -503,7 +503,7 @@ class CONTENT_EXPORT WebContentsImpl

RenderFrameHostImpl* frame,

const gfx::Rect& bounds_in_root_view) override;

void CreateNewWindow(

- SiteInstance* source_site_instance,

+ RenderFrameHost* opener,

int32_t render_view_route_id,

int32_t main_frame_route_id,

int32_t main_frame_widget_route_id,