Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)
Patch Set: Move over to render frame (but not WebFrameClient yet) + a bunch of cleanups Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index b8c4c05a75f36d8c8ec03a32b9ea652a9bbdd363..963385134f74355aff902b66f68b5b2c14704a54 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -54,6 +54,7 @@
#include "content/common/page_messages.h"
#include "content/common/render_message_filter.mojom.h"
#include "content/common/view_messages.h"
+#include "content/public/common/associated_interface_provider.h"
#include "content/public/common/bindings_policy.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/content_client.h"
@@ -1393,6 +1394,8 @@ void RenderViewImpl::OnForceRedraw(const ui::LatencyInfo& latency_info) {
// blink::WebViewClient ------------------------------------------------------
+// TODO(csharrison): Migrate this method to WebFrameClient / RenderFrameImpl, as
+// it is now serviced by a mojo interface scoped to the opener frame.
WebView* RenderViewImpl::CreateView(WebLocalFrame* creator,
const WebURLRequest& request,
const WebWindowFeatures& features,
@@ -1448,8 +1451,7 @@ WebView* RenderViewImpl::CreateView(WebLocalFrame* creator,
bool opened_by_user_gesture = params->user_gesture;
mojom::CreateNewWindowReplyPtr reply;
- RenderThreadImpl::current_render_message_filter()->CreateNewWindow(
- std::move(params), &reply);
+ creator_frame->GetFrameHostIPC()->CreateNewWindow(std::move(params), &reply);
if (reply->route_id == MSG_ROUTING_NONE)
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698