Service CreateNewWindow on the UI thread with a new mojo interface

content/browser/frame_host/render_frame_host_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 234 matching lines @@
       const gfx::Rect& bounds_in_root_view) {}
 
   // The page is trying to open a new page (e.g. a popup window). The window
   // should be created associated with the given |main_frame_widget_route_id| in
   // the process of |source_site_instance|, but it should not be shown yet. That
   // should happen in response to ShowCreatedWindow.
   // |params.window_container_type| describes the type of RenderViewHost
   // container that is requested -- in particular, the window.open call may have
   // specified 'background' and 'persistent' in the feature string.
   //
+  // The passed |opener| is the RenderFrameHost initiating the window creation.

[ncarter (slow), 2017/04/20 21:30:36]

This comment should clarify that |opener| is never null here, even if the opener
relationship on the new window is being suppressed via |params|.

[Charlie Harrison, 2017/04/21 15:30:07]

Done.

+  //
   // The passed |params.frame_name| parameter is the name parameter that was
   // passed to window.open(), and will be empty if none was passed.
   //
   // Note: this is not called "CreateWindow" because that will clash with
   // the Windows function which is actually a #define.
   //
   // The caller is expected to handle cleanup if this operation fails or is
   // suppressed, by looking for the existence of a RenderFrameHost in
   // source_site_instance's process with |main_frame_route_id| after this method

[ncarter (slow), 2017/04/20 21:30:36]

In these comment paragraphs, replace |source_site_instance| with |opener|.

[Charlie Harrison, 2017/04/21 15:30:07]

Done.

   // returns.
   virtual void CreateNewWindow(
       SiteInstance* source_site_instance,
+      RenderFrameHost* opener,

[ncarter (slow), 2017/04/20 21:30:36]

We can eliminate |source_site_instance| now that |opener| is being passed in.

[Charlie Harrison, 2017/04/21 15:30:07]

Done.

       int32_t render_view_route_id,
       int32_t main_frame_route_id,
       int32_t main_frame_widget_route_id,
       const mojom::CreateNewWindowParams& params,
       SessionStorageNamespace* session_storage_namespace) {}
 
   // Show a previously created page with the specified disposition and bounds.
   // The window is identified by the |main_frame_widget_route_id| passed to
   // CreateNewWindow.
   //
@@ skipping 25 matching lines @@
   GetJavaRenderFrameHostDelegate();
 #endif
 
  protected:
   virtual ~RenderFrameHostDelegate() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_DELEGATE_H_