Service CreateNewWindow on the UI thread with a new mojo interface

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
@@ skipping 1377 matching lines @@
 void RenderViewImpl::OnForceRedraw(const ui::LatencyInfo& latency_info) {
   if (RenderWidgetCompositor* rwc = compositor()) {
     rwc->QueueSwapPromise(
         base::MakeUnique<AlwaysDrawSwapPromise>(latency_info));
     rwc->SetNeedsForcedRedraw();
   }
 }
 
 // blink::WebViewClient ------------------------------------------------------
 
 WebView* RenderViewImpl::CreateView(WebLocalFrame* creator,

[ncarter (slow), 2017/04/17 20:52:15]

FYI: dcheng and I had discussed moving this method from WebViewClient to
WebFrameClient. I think WebFrameClient is the right place: while this is an
operation that may create a WebView, it is an operation on a particular (opener)
WebFrame.

I mention this, in case it becomes relevant with moving to use a
frame-associated mojo interface.

[Charlie Harrison, 2017/04/18 20:38:53]

Good idea. I've added a todo to do this in a followup, since this CL is getting
kinda big.

                                     const WebURLRequest& request,
                                     const WebWindowFeatures& features,
                                     const WebString& frame_name,
                                     WebNavigationPolicy policy,
                                     bool suppress_opener) {
   RenderFrameImpl* creator_frame = RenderFrameImpl::FromWebFrame(creator);
   mojom::CreateNewWindowParamsPtr params = mojom::CreateNewWindowParams::New();
   params->opener_render_frame_id = creator_frame->GetRoutingID();
   params->user_gesture = WebUserGestureIndicator::IsProcessingUserGesture();
   if (GetContentClient()->renderer()->AllowPopup())
@@ skipping 34 matching lines @@
   }
   params->features = ConvertWebWindowFeaturesToMojoWindowFeatures(features);
 
   // We preserve this information before sending the message since |params| is
   // moved on send.
   bool is_background_tab =
       params->disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB;
   bool opened_by_user_gesture = params->user_gesture;
 
   mojom::CreateNewWindowReplyPtr reply;
-  RenderThreadImpl::current_render_message_filter()->CreateNewWindow(
+  RenderThreadImpl::current_render_message_filter_ui()->CreateNewWindow(
       std::move(params), &reply);
   if (reply->route_id == MSG_ROUTING_NONE)
     return nullptr;
 
   WebUserGestureIndicator::ConsumeUserGesture();
 
   // While this view may be a background extension page, it can spawn a visible
   // render view. So we just assume that the new one is not another background
   // page instead of passing on our own value.
   // TODO(vangelis): Can we tell if the new view will be a background page?
@@ skipping 1210 matching lines @@
                             INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
   }
 
   std::unique_ptr<InputEventAck> ack(new InputEventAck(
       InputEventAckSource::MAIN_THREAD, input_event->GetType(),
       INPUT_EVENT_ACK_STATE_NOT_CONSUMED));
   OnInputEventAck(std::move(ack));
 }
 
 }  // namespace content