chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc - Issue 2821463003: Translate: remove alpha language support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 2821463003: Translate: remove alpha language support (Closed)

Patch Set: Merge branch 'master' into translate_remove_alpha Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_manager_render_view_host_unittest.cc ('k') | components/translate/core/browser/translate_download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

index f95427c56d6c0317654c52991a45234cbb1fbda6..9f45d2ca6b7b67ffaa5c9ecbf2faceb411af439b 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

@@ -225,17 +225,13 @@ void TranslateInternalsHandler::SendSupportedLanguagesToJs() {

translate::TranslateDownloadManager::GetSupportedLanguagesLastUpdated();

auto languages_list = base::MakeUnique<base::ListValue>();

- auto alpha_languages_list = base::MakeUnique<base::ListValue>();

for (std::vector<std::string>::iterator it = languages.begin();

it != languages.end(); ++it) {

const std::string& lang = *it;

languages_list->AppendString(lang);

- if (translate::TranslateDownloadManager::IsAlphaLanguage(lang))

- alpha_languages_list->AppendString(lang);

}

dict.Set("languages", std::move(languages_list));

- dict.Set("alpha_languages", std::move(alpha_languages_list));

dict.SetDouble("last_updated", last_updated.ToJsTime());

SendMessageToJs("supportedLanguagesUpdated", dict);

}