Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2821463002: Disable HTTP/2 Alternative Services. (Closed)
Patch Set: Revert change in histogram logic. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index e95ab37faf515ae8e47324e982447d4dc341c9ca..226b77efdedb0fdaf24921af2bedf762e809023a 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -398,7 +398,7 @@ class HttpNetworkTransactionTest : public PlatformTest {
HttpNetworkSession::NORMAL_SOCKET_POOL)),
old_max_pool_sockets_(ClientSocketPoolManager::max_sockets_per_pool(
HttpNetworkSession::NORMAL_SOCKET_POOL)) {
- session_deps_.enable_http2_alternative_service_with_different_host = true;
+ session_deps_.enable_http2_alternative_service = true;
}
struct SimpleGetHelperResult {
@@ -10162,12 +10162,11 @@ TEST_F(HttpNetworkTransactionTest,
EXPECT_TRUE(alternative_service_vector.empty());
}
-// HTTP/2 Alternative Services should be disabled if alternative service
-// hostname is different from that of origin.
+// HTTP/2 Alternative Services should be disabled by default.
// TODO(bnc): Remove when https://crbug.com/615413 is fixed.
TEST_F(HttpNetworkTransactionTest,
DisableHTTP2AlternativeServicesWithDifferentHost) {
- session_deps_.enable_http2_alternative_service_with_different_host = false;
+ session_deps_.enable_http2_alternative_service = false;
HttpRequestInfo request;
request.method = "GET";
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698