third_party/WebKit/Source/modules/notifications/NotificationManager.cpp - Issue 2821443002: Revert of Move ScriptState::GetExecutionContext (Part 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

Issue 2821443002: Revert of Move ScriptState::GetExecutionContext (Part 5) (Closed)

Patch Set: Revert Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp b/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

index fa84d724432bd15315ecd8fe2e3587dcc4ba2a7b..2a5851060ac93012022480fc0dbb150b23a94f81 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

@@ -63,7 +63,7 @@ mojom::blink::PermissionStatus NotificationManager::GetPermissionStatus(

ScriptPromise NotificationManager::RequestPermission(

ScriptState* script_state,

NotificationPermissionCallback* deprecated_callback) {

- ExecutionContext* context = ExecutionContext::From(script_state);

+ ExecutionContext* context = script_state->GetExecutionContext();

if (!permission_service_) {

ConnectToPermissionService(context,