Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view.cc

Issue 2821413002: views: support dialog width snapping once and for all (Closed)
Patch Set: DialogDelegateView -> BubbleDialogDelegateView Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/chooser_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
index 59837e162f7c233d3ec5ea97c236d16509f67ee2..28cf9b02f45efd10832cf2f12904e3101a5815f3 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
@@ -75,17 +75,12 @@ views::ClientView* ChooserDialogView::CreateClientView(views::Widget* widget) {
views::DialogClientView* client =
new views::DialogClientView(widget, GetContentsView());
- constexpr int kMinWidth = 402;
- constexpr int kMinHeight = 320;
- ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
- int min_width = provider->GetDialogPreferredWidth(DialogWidth::MEDIUM);
- if (!min_width)
- min_width = kMinWidth;
- client->set_minimum_size(gfx::Size(min_width, kMinHeight));
-
- client->set_button_row_insets(gfx::Insets(
- provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_VERTICAL), 0, 0,
- 0));
+ client->set_minimum_size(gfx::Size(402, 320));
+
+ client->set_button_row_insets(
+ gfx::Insets(views::LayoutProvider::Get()->GetDistanceMetric(
+ DISTANCE_UNRELATED_CONTROL_VERTICAL),
+ 0, 0, 0));
return client;
}

Powered by Google App Engine
This is Rietveld 408576698