views: support dialog width snapping once and for all

chrome/browser/ui/views/harmony/chrome_layout_provider.cc

Index: chrome/browser/ui/views/harmony/chrome_layout_provider.cc
diff --git a/chrome/browser/ui/views/harmony/chrome_layout_provider.cc b/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
index ab9efb6d4105a584a225e7a834c8607f686a7af3..1b519175d19f8bce7952f99bb49048c92f221721 100644
--- a/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
+++ b/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
@@ -84,6 +84,6 @@ bool ChromeLayoutProvider::IsHarmonyMode() const {
   return false;
 }
 
-int ChromeLayoutProvider::GetDialogPreferredWidth(DialogWidth width) const {
-  return 0;
+int ChromeLayoutProvider::GetSnappedDialogWidth(int min_width) const {

[Peter Kasting, 2017/04/19 19:26:13]

Nit: Definition order must match declaration order (see
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
)

[Elly Fong-Jones, 2017/04/20 19:53:59]

Acknowledged.

+  return min_width;

[Peter Kasting, 2017/04/19 19:26:12]

Nit: This is the same as the base class implementation; avoid overriding here as
it's unnecessary at best and a maintenance risk at worst

[Elly Fong-Jones, 2017/04/20 19:53:59]

Ooh, good point - deleted :)

 }