views: support dialog width snapping once and for all

chrome/browser/ui/views/harmony/chrome_layout_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 32 matching lines @@
   // Horizontal spacing between controls that are logically unrelated.
   DISTANCE_UNRELATED_CONTROL_HORIZONTAL,
   // Larger horizontal spacing between unrelated controls.
   DISTANCE_UNRELATED_CONTROL_HORIZONTAL_LARGE,
   // Vertical spacing between controls that are logically unrelated.
   DISTANCE_UNRELATED_CONTROL_VERTICAL,
   // Larger vertical spacing between unrelated controls.
   DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE,
 };
 
 enum class DialogWidth {

[kylix_rd, 2017/04/21 17:45:24]

This can now be removed since GetDialogPreferredWidth() is also gone.

[Elly Fong-Jones, 2017/04/21 18:25:19]

Well-spotted, thank you :) removed.

   SMALL,
   MEDIUM,
   LARGE,
 };
 
 class ChromeLayoutProvider : public views::LayoutProvider {
  public:
   ChromeLayoutProvider() {}
   ~ChromeLayoutProvider() override {}
 
   static ChromeLayoutProvider* Get();
   static std::unique_ptr<views::LayoutProvider> CreateLayoutProvider();
 
+  // views::LayoutProvider:
   int GetDistanceMetric(int metric) const override;
-
   const views::TypographyProvider& GetTypographyProvider() const override;
 
   // Returns the alignment used for control labels in a GridLayout; for example,
   // in this GridLayout:
   //   ---------------------------
   //   | Label 1      Checkbox 1 |
   //   | Label 2      Checkbox 2 |
   //   ---------------------------
   // This value controls the alignment used for "Label 1" and "Label 2".
   virtual views::GridLayout::Alignment GetControlLabelGridAlignment() const;
 
   // Returns whether to use extra padding on dialogs. If this is false, content
   // Views for dialogs should not insert extra padding at their own edges.
   virtual bool UseExtraDialogPadding() const;
 
   // Returns whether to show the icon next to the title text on a dialog.
   virtual bool ShouldShowWindowIcon() const;
 
   // DEPRECATED.  Returns whether Harmony mode is enabled.
   //
   // Instead of using this, create a generic solution that works for all UI
   // types, e.g. by adding a new LayoutDistance value that means what you need.
   //
   // TODO(pkasting): Fix callers and remove this.
   virtual bool IsHarmonyMode() const;
 
-  // Returns the preferred width in DIPs for a dialog of the specified |width|.
-  // May return 0 if the dialog has no preferred width.
-  virtual int GetDialogPreferredWidth(DialogWidth width) const;
-
  private:
   DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_