Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 282133006: Roll CLD2 from r160 -> r161 to fix a benign compilation error (Closed)

Created:
6 years, 7 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 7 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll CLD2 from r160 -> r161 to fix a benign compilation error that only surfaces when using dynamic CLD. Dynamic CLD is not currently enabled on any platforms, making this a no-op on all platforms at present. For more information, see CLD2 issue 14: https://code.google.com/p/cld2/issues/detail?id=14 BUG=367239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 7 months ago (2014-05-16 11:50:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/282133006/1
6 years, 7 months ago (2014-05-16 11:51:10 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 11:51:11 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-16 11:51:11 UTC) #4
Andrew Hayden (chromium.org)
LGTM. I've patched my own build manually and confirmed that this works when CLD_DYNAMIC_MODE is ...
6 years, 7 months ago (2014-05-16 11:53:19 UTC) #5
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 7 months ago (2014-05-16 11:54:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/282133006/1
6 years, 7 months ago (2014-05-16 11:54:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 11:54:15 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-16 11:54:15 UTC) #9
Andrew Hayden (chromium.org)
I guess my committer status is still provisional. Takashi, would you mind?
6 years, 7 months ago (2014-05-16 11:55:18 UTC) #10
Takashi Toyoshima
lgtm
6 years, 7 months ago (2014-05-16 16:50:42 UTC) #11
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-16 16:50:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/282133006/1
6 years, 7 months ago (2014-05-16 16:51:37 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 18:19:06 UTC) #14
Message was sent while issue was closed.
Change committed as 271057

Powered by Google App Engine
This is Rietveld 408576698