Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

Issue 282133005: Removes unnecessary views::Widget::InitParams::top_level (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
index c2e202b657ad07b30449624c71a0a2df1da2e92d..1d9dfa41cb986592c67591c51b6114524e390416 100644
--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
@@ -212,9 +212,6 @@ void ChromeNativeAppWindowViews::InitializeDefaultWindow(
init_params.delegate = this;
init_params.remove_standard_frame = IsFrameless() || has_frame_color_;
init_params.use_system_default_icon = true;
- // TODO(erg): Conceptually, these are toplevel windows, but we theoretically
- // could plumb context through to here in some cases.
- init_params.top_level = true;
if (create_params.transparent_background)
init_params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
init_params.keep_on_top = create_params.always_on_top;
@@ -317,9 +314,6 @@ void ChromeNativeAppWindowViews::InitializePanelWindow(
#else
params.bounds = gfx::Rect(preferred_size_);
#endif
- // TODO(erg): Conceptually, these are toplevel windows, but we theoretically
- // could plumb context through to here in some cases.
- params.top_level = true;
widget()->Init(params);
widget()->set_focus_on_creation(create_params.focused);
« no previous file with comments | « ash/shell/content_client/shell_browser_main_parts.cc ('k') | chrome/browser/ui/views/chrome_views_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698