Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: device/u2f/u2f_register.cc

Issue 2821263005: Add U2F request state machines (Closed)
Patch Set: Compilation changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/u2f/u2f_register.cc
diff --git a/device/u2f/u2f_register.cc b/device/u2f/u2f_register.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a8d7aa0cdfeb8587467f32ef8dcde7bc05259764
--- /dev/null
+++ b/device/u2f/u2f_register.cc
@@ -0,0 +1,63 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "u2f_register.h"
+
+#include "base/memory/ptr_util.h"
+
+namespace device {
+
+U2fRegister::U2fRegister(std::vector<uint8_t> challenge_hash,
+ std::vector<uint8_t> app_param,
+ const ResponseCallback& cb)
+ : U2fRequest(cb),
+ challenge_hash_(challenge_hash),
+ app_param_(app_param),
+ weak_factory_(this) {}
+
+U2fRegister::~U2fRegister() {}
+
+// static
+std::unique_ptr<U2fRequest> U2fRegister::TryRegistration(
+ std::vector<uint8_t> challenge_hash,
+ std::vector<uint8_t> app_param,
+ const ResponseCallback& cb) {
+ std::unique_ptr<U2fRequest> request =
+ base::MakeUnique<U2fRegister>(challenge_hash, app_param, cb);
+ if (request)
Reilly Grant (use Gerrit) 2017/04/21 17:19:16 base::MakeUnique cannot fail.
Casey Piper 2017/04/21 18:42:26 Acknowledged.
+ request->Start();
+ return request;
+}
+
+void U2fRegister::TryDevice() {
+ if (!current_device_)
+ return;
Reilly Grant (use Gerrit) 2017/04/21 17:19:16 DCHECK?
Casey Piper 2017/04/21 18:42:26 Done.
+
+ current_device_->Register(
+ app_param_, challenge_hash_,
+ base::Bind(&U2fRegister::OnTryDevice, weak_factory_.GetWeakPtr()));
+}
+
+void U2fRegister::OnTryDevice(U2fDevice::ReturnCode return_code,
+ std::vector<uint8_t> response_data) {
+ switch (return_code) {
+ case U2fDevice::ReturnCode::SUCCESS:
+ state_ = State::COMPLETE;
+ cb_.Run(static_cast<uint8_t>(return_code), response_data);
+ break;
+ case U2fDevice::ReturnCode::CONDITIONS_NOT_SATISFIED:
+ // Waiting for user touch, move on and try this device later
+ state_ = State::IDLE;
+ Transition();
+ break;
+ default:
+ state_ = State::IDLE;
+ // An error has occured, quit trying this device
+ current_device_ = nullptr;
+ Transition();
+ break;
+ }
+}
+
+} // namespace device

Powered by Google App Engine
This is Rietveld 408576698