device/u2f/u2f_device.cc - Issue 2821263005: Add U2F request state machines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/u2f/u2f_device.cc

Issue 2821263005: Add U2F request state machines (Closed)

Patch Set: Add U2fRequest, U2fSign, and U2fRegister classes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/u2f/u2f_device.cc

diff --git a/device/u2f/u2f_device.cc b/device/u2f/u2f_device.cc

index dc9e5ec127be1845cb71dc3f1d731cf4cab7caf3..c531f1733ecb405a1e6056371397f8a4338c7f37 100644

--- a/device/u2f/u2f_device.cc

+++ b/device/u2f/u2f_device.cc

@@ -95,10 +95,9 @@ void U2fDevice::OnSignComplete(const MessageCallback& callback,

callback.Run(ReturnCode::SUCCESS, sign_response->data());

break;

case U2fApduResponse::Status::SW_WRONG_DATA:

- callback.Run(ReturnCode::INVALID_PARAMS, std::vector<uint8_t>());

- break;

+ case U2fApduResponse::Status::SW_WRONG_LENGTH:

default:

- callback.Run(ReturnCode::FAILURE, std::vector<uint8_t>());

+ callback.Run(ReturnCode::INVALID_PARAMS, std::vector<uint8_t>());

break;

}