Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Issue 2821233005: Allow signature functions to be allocated in new space. (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow signature functions to be allocated in new space. Types generated via instantiation during run time type tests are allocated in new space and it makes sense (in the case of function types) to also allocate instantiated signatures in new space. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f0622c0567bc194b874675ea8b91e415cc73edaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M runtime/vm/object.h View 4 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 8 months ago (2017-04-19 01:20:55 UTC) #2
siva
lgtm
3 years, 8 months ago (2017-04-19 17:07:40 UTC) #3
regis
3 years, 8 months ago (2017-04-19 17:10:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0622c0567bc194b874675ea8b91e415cc73edaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698