Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java

Issue 2821223004: [Home] Show the app menu icons as a footer (Closed)
Patch Set: Changes from tedchoc@ review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..6c7fbb268d2e02514c0ccc950ba8419ae721e34a
--- /dev/null
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java
@@ -0,0 +1,87 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.appmenu;
+
+import android.support.test.filters.SmallTest;
+
+import org.chromium.base.ThreadUtils;
+import org.chromium.base.test.util.UrlUtils;
+import org.chromium.chrome.test.BottomSheetTestCaseBase;
+import org.chromium.content.browser.test.util.Criteria;
+import org.chromium.content.browser.test.util.CriteriaHelper;
+
+/**
+ * Tests for the app menu when Chrome Home is enabled.
+ */
+public class ChromeHomeAppMenuTest extends BottomSheetTestCaseBase {
+ private static final String TEST_URL = UrlUtils.encodeHtmlDataUri("<html>foo</html>");
+ private AppMenuHandler mAppMenuHandler;
+
+ @Override
+ protected void setUp() throws Exception {
+ super.setUp();
+
+ mAppMenuHandler = getActivity().getAppMenuHandler();
+ }
+
+ @SmallTest
+ public void testPageMenu() throws IllegalArgumentException, InterruptedException {
+ loadUrl(TEST_URL);
+
+ showAppMenuAndAssertMenuShown();
+ AppMenu appMenu = getActivity().getAppMenuHandler().getAppMenu();
+ AppMenuIconRowFooter iconRow = (AppMenuIconRowFooter) appMenu.getPromptView();
+
+ assertFalse(iconRow.getForwardButtonForTests().isEnabled());
+ assertTrue(iconRow.getBookmarkButtonForTests().isEnabled());
+ // Only HTTP/S pages can be downloaded.
+ assertFalse(iconRow.getDownloadButtonForTests().isEnabled());
+ assertTrue(iconRow.getPageInfoButtonForTests().isEnabled());
+ assertTrue(iconRow.getReloadButtonForTests().isEnabled());
+
+ // Navigate backward, open the menu and assert forward button is enabled.
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ mAppMenuHandler.hideAppMenu();
+ getActivity().getActivityTab().goBack();
+ }
+ });
+
+ showAppMenuAndAssertMenuShown();
+ iconRow = (AppMenuIconRowFooter) appMenu.getPromptView();
+ assertTrue(iconRow.getForwardButtonForTests().isEnabled());
+ }
+
+ @SmallTest
+ public void testTabSwitcherMenu() throws IllegalArgumentException {
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ getActivity().getLayoutManager().showOverview(false);
+ }
+ });
+
+ showAppMenuAndAssertMenuShown();
+ AppMenu appMenu = getActivity().getAppMenuHandler().getAppMenu();
+
+ assertNull(appMenu.getPromptView());
+ }
+
+ private void showAppMenuAndAssertMenuShown() {
+ ThreadUtils.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ mAppMenuHandler.showAppMenu(null, false);
+ }
+ });
+ CriteriaHelper.pollUiThread(new Criteria("AppMenu did not show") {
+ @Override
+ public boolean isSatisfied() {
+ return mAppMenuHandler.isAppMenuShowing();
+ }
+ });
+ }
+}
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698