[Home] Show the app menu icons as a footer

chrome/android/java/res/layout/icon_row_menu_footer.xml

Index: chrome/android/java/res/layout/icon_row_menu_footer.xml
diff --git a/chrome/android/java/res/layout/icon_row_menu_footer.xml b/chrome/android/java/res/layout/icon_row_menu_footer.xml
new file mode 100644
index 0000000000000000000000000000000000000000..d3ad316ce4654a8c39b16ef13223eff8447df35a
--- /dev/null
+++ b/chrome/android/java/res/layout/icon_row_menu_footer.xml
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file.
+-->
+<org.chromium.chrome.browser.appmenu.AppMenuIconRowFooter
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:chrome="http://schemas.android.com/apk/res-auto"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:orientation="vertical" >
+
+    <View style="@style/Divider" />
+
+    <LinearLayout

[Ted C, 2017/04/18 22:58:46]

I was thinking it would be nice to share icon_row_menu_item.xml here.  Even in
the "medium" term I think we'll end up needing both since custom tabs will
likely have a top menu in the chrome home world.

I'm curious why we need the tint to handle disabled here, but I didn't spot
anything like that in the menu (although that code is not exactly clear).

It would be good to find a way to converge (even if we ended up just using this
layout for the menu and got rid of the overly flexible icon_row_menu_item)...I
think that can be a TODO for now to find a path to merge these to unblock this
though.

[Theresa, 2017/04/18 23:30:59]

I agree. Added a TODO.

+        android:layout_width="match_parent"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
+        android:orientation="horizontal"
+        android:id="@+id/menu_items" >
+
+        <org.chromium.chrome.browser.widget.TintedImageButton
+            android:id="@+id/forward_menu_id"
+            style="@style/AppMenuIconRowIcon"
+            android:src="@drawable/btn_forward"
+            android:contentDescription="@string/accessibility_menu_forward"
+            chrome:tint="@color/app_menu_button_tint" />
+
+        <org.chromium.chrome.browser.widget.TintedImageButton
+            android:id="@+id/bookmark_this_page_id"
+            style="@style/AppMenuIconRowIcon"
+            android:src="@drawable/btn_star"
+            android:contentDescription="@string/accessibility_menu_bookmark"
+            chrome:tint="@color/app_menu_button_tint" />
+
+        <org.chromium.chrome.browser.widget.TintedImageButton
+            android:id="@+id/offline_page_id"
+            style="@style/AppMenuIconRowIcon"
+            android:src="@drawable/ic_file_download_white_24dp"
+            android:contentDescription="@string/download_page"
+            chrome:tint="@color/app_menu_button_tint" />
+
+        <org.chromium.chrome.browser.widget.TintedImageButton
+            android:id="@+id/info_menu_id"
+            style="@style/AppMenuIconRowIcon"
+            android:src="@drawable/btn_info"
+            android:contentDescription="@string/accessibility_menu_info"
+            chrome:tint="@color/app_menu_button_tint" />
+
+        <org.chromium.chrome.browser.widget.TintedImageButton
+            android:id="@+id/reload_menu_id"
+            style="@style/AppMenuIconRowIcon"
+            android:src="@drawable/btn_reload_stop"
+            android:contentDescription="@string/accessibility_btn_refresh"
+            chrome:tint="@color/app_menu_button_tint" />
+    </LinearLayout>
+</org.chromium.chrome.browser.appmenu.AppMenuIconRowFooter>