Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2821223004: [Home] Show the app menu icons as a footer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 <item name="android:layout_width">wrap_content</item> 579 <item name="android:layout_width">wrap_content</item>
580 <item name="android:layout_height">wrap_content</item> 580 <item name="android:layout_height">wrap_content</item>
581 <item name="android:layout_gravity">center_vertical</item> 581 <item name="android:layout_gravity">center_vertical</item>
582 <item name="android:singleLine">true</item> 582 <item name="android:singleLine">true</item>
583 <item name="android:textColor">@android:color/white</item> 583 <item name="android:textColor">@android:color/white</item>
584 <item name="android:textSize">20sp</item> 584 <item name="android:textSize">20sp</item>
585 </style> 585 </style>
586 <style name="BottomSheetContentTitle" parent="TextAppearance.Widget.AppCompa t.Toolbar.Title"> 586 <style name="BottomSheetContentTitle" parent="TextAppearance.Widget.AppCompa t.Toolbar.Title">
587 <item name="android:textSize">20sp</item> 587 <item name="android:textSize">20sp</item>
588 </style> 588 </style>
589 <style name="AppMenuIconRowIcon">
Ted C 2017/04/18 22:58:46 Any reason OverflowMenuButton doesn't work here?
Theresa 2017/04/18 23:30:59 None at all. I removed this style.
590 <item name="android:layout_width">0dp</item>
591 <item name="android:layout_weight">1</item>
592 <item name="android:layout_height">match_parent</item>
593 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>
594 </style>
589 595
590 <!-- New tab page RecyclerView overscroll color --> 596 <!-- New tab page RecyclerView overscroll color -->
591 <style name="NewTabPageRecyclerView"> 597 <style name="NewTabPageRecyclerView">
592 <item name="android:colorEdgeEffect">@color/google_grey_300</item> 598 <item name="android:colorEdgeEffect">@color/google_grey_300</item>
593 </style> 599 </style>
594 600
595 <!-- History UI --> 601 <!-- History UI -->
596 <style name="HistoryStartIcon"> 602 <style name="HistoryStartIcon">
597 <item name="android:layout_width">@dimen/selectable_list_layout_start_ic on_width</item> 603 <item name="android:layout_width">@dimen/selectable_list_layout_start_ic on_width</item>
598 <item name="android:layout_height">match_parent</item> 604 <item name="android:layout_height">match_parent</item>
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 <style name="IncognitoNewTabLearnMoreLink"> 721 <style name="IncognitoNewTabLearnMoreLink">
716 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> 722 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>
717 <item name="android:clickable">true</item> 723 <item name="android:clickable">true</item>
718 <item name="android:focusable">true</item> 724 <item name="android:focusable">true</item>
719 <item name="android:textSize">14sp</item> 725 <item name="android:textSize">14sp</item>
720 <item name="android:textAllCaps">true</item> 726 <item name="android:textAllCaps">true</item>
721 <item name="android:padding">16dp</item> 727 <item name="android:padding">16dp</item>
722 </style> 728 </style>
723 729
724 </resources> 730 </resources>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698