Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: src/lookup.h

Issue 2821213004: [keyed-store-generic] Update protectors if needed (Closed)
Patch Set: --no-stress-opt Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/keyed-store-generic.cc ('k') | test/mjsunit/keyed-store-generic.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 710010bd03a5a63844f74a9ea0ac123c994df2c6..687657ae65625dfef0db9f9ce223a3902cc11292 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -260,10 +260,11 @@ class V8_EXPORT_PRIVATE LookupIterator final BASE_EMBEDDED {
void WriteDataValue(Handle<Object> value, bool initializing_store);
inline void UpdateProtector() {
if (IsElement()) return;
+ // This list must be kept in sync with
+ // CodeStubAssembler::HasAssociatedProtector!
if (*name_ == heap()->is_concat_spreadable_symbol() ||
*name_ == heap()->constructor_string() ||
*name_ == heap()->species_symbol() ||
- *name_ == heap()->has_instance_symbol() ||
*name_ == heap()->iterator_symbol()) {
InternalUpdateProtector();
}
« no previous file with comments | « src/ic/keyed-store-generic.cc ('k') | test/mjsunit/keyed-store-generic.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698