Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: content/renderer/media/mojo_audio_output_ipc.cc

Issue 2821203005: Add a mojo implementation of AudioOutputIPC. (Closed)
Patch Set: Use ScopedClosureRunner. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/mojo_audio_output_ipc.cc
diff --git a/content/renderer/media/mojo_audio_output_ipc.cc b/content/renderer/media/mojo_audio_output_ipc.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f3c6a5416688efc463ece7cc8631b18792773791
--- /dev/null
+++ b/content/renderer/media/mojo_audio_output_ipc.cc
@@ -0,0 +1,200 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/mojo_audio_output_ipc.h"
+
+#include <utility>
+
+#include "media/audio/audio_device_description.h"
+#include "mojo/public/cpp/system/platform_handle.h"
+
+namespace content {
+
+namespace {
+
+void TrivialAuthorizedCallback(media::OutputDeviceStatus,
+ const media::AudioParameters&,
+ const std::string&) {}
+
+} // namespace
+
+MojoAudioOutputIPC::MojoAudioOutputIPC(FactoryAccessorCB factory_accessor)
+ : factory_accessor_(std::move(factory_accessor)), weak_factory_(this) {
+ DETACH_FROM_THREAD(thread_checker_);
+}
+
+MojoAudioOutputIPC::~MojoAudioOutputIPC() {
+ DCHECK(!AuthorizationRequested() && !StreamCreationRequested())
+ << "CloseStream must be called before destructing the AudioOutputIPC";
+ // No thread check.
+ // Destructing |weak_factory_| on any thread is safe since it's not used after
+ // the final call to CloseStream, where its pointers are invalidated.
+}
+
+void MojoAudioOutputIPC::RequestDeviceAuthorization(
+ media::AudioOutputIPCDelegate* delegate,
+ int session_id,
+ const std::string& device_id,
+ const url::Origin& security_origin) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ DCHECK(delegate);
+ DCHECK(!delegate_);
+ DCHECK(!AuthorizationRequested());
+ DCHECK(!StreamCreationRequested());
+ delegate_ = delegate;
+
+ // We pass in a ScopedClosureRunner to detect the case when the mojo
+ // connection is terminated prior to receiving the response. In this case,
+ // the closure runner will be destructed and call ReceivedDeviceAuthorization
+ // with an error.
+ DoRequestDeviceAuthorization(
+ session_id, device_id,
+ base::BindOnce(
+ &MojoAudioOutputIPC::ReceivedDeviceAuthorization,
+ weak_factory_.GetWeakPtr(),
+ base::ScopedClosureRunner(base::Bind(
+ &MojoAudioOutputIPC::ReceivedDeviceAuthorization,
+ weak_factory_.GetWeakPtr(),
+ base::Passed(base::ScopedClosureRunner()),
+ media::OutputDeviceStatus::OUTPUT_DEVICE_STATUS_ERROR_INTERNAL,
+ media::AudioParameters::UnavailableDeviceParams(),
+ std::string()))));
+}
+
+void MojoAudioOutputIPC::CreateStream(media::AudioOutputIPCDelegate* delegate,
+ const media::AudioParameters& params) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ DCHECK(delegate);
+ DCHECK(!StreamCreationRequested());
+ if (!AuthorizationRequested()) {
+ DCHECK(!delegate_);
+ delegate_ = delegate;
+ // No authorization requested yet. Request one for the default device.
+ // Since the delegate didn't explicitly request authorization, we shouldn't
+ // send a callback to it.
+ if (!DoRequestDeviceAuthorization(
+ 0, media::AudioDeviceDescription::kDefaultDeviceId,
+ base::Bind(&TrivialAuthorizedCallback))) {
+ return;
+ }
+ }
+
+ DCHECK_EQ(delegate_, delegate);
+ // Since the creation callback won't fire if the provider binding is gone
+ // and |this| owns |stream_provider_|, unretained is safe.
+ stream_provider_->Acquire(
+ mojo::MakeRequest(&stream_), params,
+ base::Bind(&MojoAudioOutputIPC::StreamCreated, base::Unretained(this)));
+
+ // Unretained is safe because |delegate_| must remain valid until
+ // CloseStream is called, and |stream_provider_| is reset in CloseStream.
+ stream_.set_connection_error_handler(base::Bind(
+ &media::AudioOutputIPCDelegate::OnError, base::Unretained(delegate_)));
+}
+
+void MojoAudioOutputIPC::PlayStream() {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ if (stream_.is_bound())
+ stream_->Play();
+}
+
+void MojoAudioOutputIPC::PauseStream() {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ if (stream_.is_bound())
+ stream_->Pause();
+}
+
+void MojoAudioOutputIPC::CloseStream() {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ stream_provider_.reset();
+ stream_.reset();
+ delegate_ = nullptr;
+
+ // Cancel any pending callbacks for this stream.
+ weak_factory_.InvalidateWeakPtrs();
+}
+
+void MojoAudioOutputIPC::SetVolume(double volume) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ if (stream_.is_bound())
+ stream_->SetVolume(volume);
+}
+
+bool MojoAudioOutputIPC::AuthorizationRequested() {
+ return stream_provider_.is_bound();
+}
+
+bool MojoAudioOutputIPC::StreamCreationRequested() {
+ return stream_.is_bound();
+}
+
+media::mojom::AudioOutputStreamProviderRequest
+MojoAudioOutputIPC::MakeProviderRequest() {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ DCHECK(!AuthorizationRequested());
+ media::mojom::AudioOutputStreamProviderRequest request =
+ mojo::MakeRequest(&stream_provider_);
+
+ // Unretained is safe because |delegate_| must remain valid until
+ // CloseStream is called, and |stream_provider_| is reset in CloseStream.
+ stream_provider_.set_connection_error_handler(base::Bind(
+ &media::AudioOutputIPCDelegate::OnError, base::Unretained(delegate_)));
+ return request;
+}
+
+bool MojoAudioOutputIPC::DoRequestDeviceAuthorization(
+ int session_id,
+ const std::string& device_id,
+ AuthorizationCB callback) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ auto* factory = factory_accessor_.Run();
+ if (!factory) {
+ LOG(ERROR) << "MojoAudioOutputIPC failed to acquire factory";
+
+ media::AudioOutputIPCDelegate* delegate = delegate_;
+ CloseStream();
+ delegate->OnIPCClosed(); // deletes |this|.
+ return false;
+ }
+
+ factory->RequestDeviceAuthorization(MakeProviderRequest(), session_id,
+ device_id, std::move(callback));
+ return true;
+}
+
+void MojoAudioOutputIPC::ReceivedDeviceAuthorization(
+ base::ScopedClosureRunner fallback_closure,
+ media::OutputDeviceStatus status,
+ const media::AudioParameters& params,
+ const std::string& device_id) const {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ DCHECK(delegate_);
+ ignore_result(fallback_closure.Release());
+ delegate_->OnDeviceAuthorized(status, params, device_id);
+}
+
+void MojoAudioOutputIPC::StreamCreated(
+ mojo::ScopedSharedBufferHandle shared_memory,
+ mojo::ScopedHandle socket) {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
+ DCHECK(delegate_);
+ DCHECK(socket.is_valid());
+ DCHECK(shared_memory.is_valid());
+
+ base::PlatformFile socket_handle;
+ auto result = mojo::UnwrapPlatformFile(std::move(socket), &socket_handle);
+ DCHECK_EQ(result, MOJO_RESULT_OK);
+
+ base::SharedMemoryHandle memory_handle;
+ bool read_only = false;
+ size_t memory_length = 0;
+ result = mojo::UnwrapSharedMemoryHandle(
+ std::move(shared_memory), &memory_handle, &memory_length, &read_only);
+ DCHECK_EQ(result, MOJO_RESULT_OK);
+ DCHECK(!read_only);
+
+ delegate_->OnStreamCreated(memory_handle, socket_handle, memory_length);
+}
+
+} // namespace content
« no previous file with comments | « content/renderer/media/mojo_audio_output_ipc.h ('k') | content/renderer/media/mojo_audio_output_ipc_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698